linux-kernel - Re: [PATCH -next] drm/vmwgfx: Remove set but not used variable 'fb_offset, fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53a45c6dc200247288ce70a22c06e2f1db4c5497.camel@vmware.com>
Date:   Mon, 25 Mar 2019 17:26:36 +0000
From:   Deepak Singh Rawat <drawat@...are.com>
To:     YueHaibing <yuehaibing@...wei.com>,
        Linux-graphics-maintainer <Linux-graphics-maintainer@...are.com>,
        Thomas Hellstrom <thellstrom@...are.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH -next] drm/vmwgfx: Remove set but not used variable
 'fb_offset, fb_depth'

Thanks for doing this.

Reviewed-by: Deepak Rawat <drawat@...are.com>

On Sat, 2019-03-23 at 02:46 +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/gpu/drm/vmwgfx/vmwgfx_fb.c: In function 'vmw_fb_init':
> drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:645:29: warning:
>  variable 'fb_offset' set but not used [-Wunused-but-set-variable]
> 
> drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:645:19: warning:
>  variable 'fb_depth' set but not used [-Wunused-but-set-variable]
> 
> They're not used any more, so can be removed.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
> b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
> index 2a9112515f46..86efb91f5034 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
> @@ -642,12 +642,11 @@ int vmw_fb_init(struct vmw_private *vmw_priv)
>  	struct vmw_fb_par *par;
>  	struct fb_info *info;
>  	unsigned fb_width, fb_height;
> -	unsigned fb_bpp, fb_depth, fb_offset, fb_pitch, fb_size;
> +	unsigned fb_bpp, fb_pitch, fb_size;
>  	struct drm_display_mode *init_mode;
>  	int ret;
>  
>  	fb_bpp = 32;
> -	fb_depth = 24;
>  
>  	/* XXX As shouldn't these be as well. */
>  	fb_width = min(vmw_priv->fb_max_width, (unsigned)2048);
> @@ -655,7 +654,6 @@ int vmw_fb_init(struct vmw_private *vmw_priv)
>  
>  	fb_pitch = fb_width * fb_bpp / 8;
>  	fb_size = fb_pitch * fb_height;
> -	fb_offset = vmw_read(vmw_priv, SVGA_REG_FB_OFFSET);
>  
>  	info = framebuffer_alloc(sizeof(*par), device);
>  	if (!info)
> 
> 
>