linux-kernel - Re: [PATCH 2/8] tools/lib/traceevent: Add counter to track parsing failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190326154847.4c1062b9@gandalf.local.home>
Date:   Tue, 26 Mar 2019 15:48:47 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Tzvetomir Stoyanov <tstoyanov@...are.com>
Cc:     linux-trace-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/8] tools/lib/traceevent: Add counter to track parsing
 failures

On Tue, 26 Mar 2019 17:43:22 +0200
Tzvetomir Stoyanov <tstoyanov@...are.com> wrote:

> This patch adds a parsing failures counter to struct tep_handle. The counter can
> be used to track failures on parsing event format files. It is updated
> automatically by tep_parse_event(), when failure is detected. The patch also
> adds two new APIs for accessing the counter:
>  tep_get_parsing_failures() - returns the current value of the counter.
>  tep_clear_parsing_failures() - clears the counter.
> 

I think we can do the same thing here as we did test_filters.

I don't think we really need to put this into the tep interface. Let's
see if we can move this into trace-cmd itself and have it just keep
track of when parsing failed.

I mean, trace-cmd is just using the tep structure as place to store
this variable.

-- Steve