linux-kernel - Re: [PATCH v3] RISC-V: Always compile mm/init.c with cmodel=medany and notrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhSdy1XsLkrJRyzi9WV6uAi+WFC420hs_asE=1oQ5L2ZrTuOg@mail.gmail.com>
Date:   Tue, 26 Mar 2019 09:27:53 +0530
From:   Anup Patel <anup@...infault.org>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Anup Patel <Anup.Patel@....com>,
        Palmer Dabbelt <palmer@...ive.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Atish Patra <Atish.Patra@....com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH v3] RISC-V: Always compile mm/init.c with cmodel=medany
 and notrace

On Mon, Mar 25, 2019 at 5:08 PM Christoph Hellwig <hch@...radead.org> wrote:
>
> > +ifdef CONFIG_FTRACE
> > +CFLAGS_REMOVE_init.o = -pg
> > +endif
> > +
> >  obj-y += init.o
> >  obj-y += fault.o
> >  obj-y += extable.o
> >  obj-y += ioremap.o
> >  obj-y += cacheflush.o
> > +
> > +CFLAGS_init.o := -mcmodel=medany
>
> Can you keep the two flags adjustments togther, preferably towards
> the top of the file?

Sure, I will more the flags together.

>
> > +/*
> > + * The setup_vm() is called from head.S with MMU-off.
>
> s/The //g

Okay, I will update.

>
> Otherwis looks fine:
>
> Reviewed-by: Christoph Hellwig <hch@....de>

Regards,
Anup