linux-kernel - Re: [PATCH ghak109 V2] audit: link integrity evm_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1553632830.4233.3.camel@linux.ibm.com>
Date:   Tue, 26 Mar 2019 16:40:30 -0400
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Richard Guy Briggs <rgb@...hat.com>,
        linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        Linux-Audit Mailing List <linux-audit@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     Paul Moore <paul@...l-moore.com>, sgrubb@...hat.com,
        omosnace@...hat.com, eparis@...isplace.org, serge@...lyn.com,
        mjg59@...gle.com
Subject: Re: [PATCH ghak109 V2] audit: link integrity evm_write_xattrs
 record to syscall event

Hi Richard, Paul,

On Tue, 2019-03-26 at 14:49 -0400, Richard Guy Briggs wrote:
> In commit fa516b66a1bf ("EVM: Allow runtime modification of the set of
> verified xattrs"), the call to audit_log_start() is missing a context to
> link it to an audit event. Since this event is in user context, add
> the process' syscall context to the record.
> 
> In addition, the orphaned keyword "locked" appears in the record.
> Normalize this by changing it to logging the locking string "." as any
> other user input in the "xattr=" field.
> 
> Please see the github issue
> https://github.com/linux-audit/audit-kernel/issues/109
> 
> Signed-off-by: Richard Guy Briggs <rgb@...hat.com>

Acked-by: Mimi Zohar <zohar@...ux.ibm.com>

Paul, were you planning on upstreaming this patch?

Mimi