linux-kernel - Re: [PATCH v6 1/4] arm64: dts: imx8mq: Add SDMA nodes

Open Source and information security mailing list archives

Date:   Tue, 26 Mar 2019 14:44:21 -0700
From:   Angus Ainslie <angus@...ea.ca>
To:     Shawn Guo <shawnguo@...nel.org>
Cc:     Daniel Baluta <daniel.baluta@....com>, mark.rutland@....com,
        devicetree@...r.kernel.org, baruch@...s.co.il,
        Anson Huang <anson.huang@....com>,
        Abel Vesa <abel.vesa@....com>,
        kuninori.morimoto.gx@...esas.com, ccaione@...libre.com,
        spencercw@...il.com, "S.j. Wang" <shengjiu.wang@....com>,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        dl-linux-imx <linux-imx@....com>, kernel@...gutronix.de,
        Aisheng Dong <aisheng.dong@....com>, agx@...xcpu.org,
        festevam@...il.com, s.hauer@...gutronix.de,
        linux-arm-kernel@...ts.infradead.org, l.stach@...gutronix.de
Subject: Re: [PATCH v6 1/4] arm64: dts: imx8mq: Add SDMA nodes

On 2019-03-19 07:31, Shawn Guo wrote:
> On Fri, Mar 08, 2019 at 12:02:22PM +0000, Daniel Baluta wrote:
>> SDMA1 is part of AIPS-3 region and SDMA2 is part
>> of AIPS-1 region.
>> 
>> Reviewed-by: Fabio Estevam <festevam@...il.com>
> 
> Reviewed-by tag should go after your SoB, since that's the sequence of
> how they come.
> 
>> Signed-off-by: Anson Huang <Anson.Huang@....com>
>> [initial submit in i.MX internal tree]
>> Signed-off-by: Daniel Baluta <daniel.baluta@....com>
>> [adaptation for linux-next]
> 
> I would see these notes in commit log or even just cover letter.
> 
> Shawn
> 
>> ---
>>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++++++++++++++++++++++
>>  1 file changed, 22 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi 
>> b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> index 9155bd4784eb..9d48450453fb 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> @@ -234,6 +234,17 @@
>>  				status = "disabled";
>>  			};
>> 
>> +			sdma2: sdma@...c0000 {
>> +				compatible = "fsl,imx8mq-sdma","fsl,imx7d-sdma";
>> +				reg = <0x302c0000 0x10000>;
>> +				interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
>> +				clocks = <&clk IMX8MQ_CLK_SDMA2_ROOT>,
>> +					 <&clk IMX8MQ_CLK_SDMA2_ROOT>;
>> +				clock-names = "ipg", "ahb";
>> +				#dma-cells = <3>;
>> +				fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin";
>> +			};
>> +
>>  			iomuxc: iomuxc@...30000 {
>>  				compatible = "fsl,imx8mq-iomuxc";
>>  				reg = <0x30330000 0x10000>;
>> @@ -575,6 +586,17 @@
>>  				status = "disabled";
>>  			};
>> 
>> +			sdma1: sdma@...d0000 {
>> +				compatible = "fsl, imx8mq-sdma","fsl,imx7d-sdma";

There shouldn't be a space in the imx8mq compatible string.

Angus

>> +				reg = <0x30bd0000 0x10000>;
>> +				interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
>> +				clocks = <&clk IMX8MQ_CLK_SDMA1_ROOT>,
>> +					 <&clk IMX8MQ_CLK_SDMA1_ROOT>;
>> +				clock-names = "ipg", "ahb";
>> +				#dma-cells = <3>;
>> +				fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin";
>> +			};
>> +
>>  			fec1: ethernet@...e0000 {
>>  				compatible = "fsl,imx8mq-fec", "fsl,imx6sx-fec";
>>  				reg = <0x30be0000 0x10000>;
>> --
>> 2.17.1
>> 
>> 
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@...ts.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives