lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 26 Mar 2019 15:30:28 +0900
From:   Greg Kroah-Hartman <>
Cc:     Greg Kroah-Hartman <>,,
        Tetsuo Handa <>,
        Shayenne Moura <>,
        Daniel Vetter <>,
        syzbot <>
Subject: [PATCH 5.0 41/52] drm/vkms: Fix flush_work() without INIT_WORK().

5.0-stable review patch.  If anyone has any objections, please let me know.


From: Tetsuo Handa <>

commit b30b61ff6b1dc37f276cf56a8328b80086a3ffca upstream.

syzbot is hitting a lockdep warning [1] because flush_work() is called
without INIT_WORK() after kzalloc() at vkms_atomic_crtc_reset().

Commit 6c234fe37c57627a ("drm/vkms: Implement CRC debugfs API") added
INIT_WORK() to only vkms_atomic_crtc_duplicate_state() side. Assuming
that lifecycle of crc_work is appropriately managed, fix this problem
by adding INIT_WORK() to vkms_atomic_crtc_reset() side.


Reported-and-tested-by: syzbot <>
Signed-off-by: Tetsuo Handa <>
Reviewed-by: Shayenne Moura <>
Signed-off-by: Daniel Vetter <>
Signed-off-by: Greg Kroah-Hartman <>

 drivers/gpu/drm/vkms/vkms_crtc.c |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/gpu/drm/vkms/vkms_crtc.c
+++ b/drivers/gpu/drm/vkms/vkms_crtc.c
@@ -98,6 +98,7 @@ static void vkms_atomic_crtc_reset(struc
 	vkms_state = kzalloc(sizeof(*vkms_state), GFP_KERNEL);
 	if (!vkms_state)
+	INIT_WORK(&vkms_state->crc_work, vkms_crc_work_handle);
 	crtc->state = &vkms_state->base;
 	crtc->state->crtc = crtc;

Powered by blists - more mailing lists