lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 26 Mar 2019 15:30:03 +0900
From:   Greg Kroah-Hartman <>
Cc:     Greg Kroah-Hartman <>,, Vassili Karpov <>,
        Josh Poimboeuf <>,
        Thomas Gleixner <>,
        Peter Zijlstra <>
Subject: [PATCH 4.19 20/45] objtool: Move objtool_file struct off the stack

4.19-stable review patch.  If anyone has any objections, please let me know.


From: Josh Poimboeuf <>

commit 0c671812f152b628bd87c0af49da032cc2a2c319 upstream.

Objtool uses over 512k of stack, thanks to the hash table embedded in
the objtool_file struct.  This causes an unnecessarily large stack
allocation and breaks users with low stack limits.

Move the struct off the stack.

Fixes: 042ba73fe7eb ("objtool: Add several performance improvements")
Reported-by: Vassili Karpov <>
Signed-off-by: Josh Poimboeuf <>
Signed-off-by: Thomas Gleixner <>
Cc: Peter Zijlstra <>
Signed-off-by: Greg Kroah-Hartman <>

 tools/objtool/check.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -2157,9 +2157,10 @@ static void cleanup(struct objtool_file
+static struct objtool_file file;
 int check(const char *_objname, bool orc)
-	struct objtool_file file;
 	int ret, warnings = 0;
 	objname = _objname;

Powered by blists - more mailing lists