linux-kernel - Re: [PATCH v1] phy: qcom-qmp: Add msm8998 PCIe QMP PHY support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 Mar 2019 13:31:24 +0530
From:   Vivek Gautam <vivek.gautam@...eaurora.org>
To:     Marc Gonzalez <marc.w.gonzalez@...e.fr>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        Andy Gross <andy.gross@...aro.org>,
        Jeffrey Hugo <jhugo@...eaurora.org>,
        Evan Green <evgreen@...omium.org>,
        MSM <linux-arm-msm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] phy: qcom-qmp: Add msm8998 PCIe QMP PHY support

Hi Marc,

On Tue, Mar 26, 2019 at 1:18 PM Kishon Vijay Abraham I <kishon@...com> wrote:
>
> Hi,
>
> On 22/03/19 9:42 PM, Marc Gonzalez wrote:
> > Copy init sequence from downstream:
> > https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/msm8998-v2.dtsi?h=LE.UM.1.3.r3.25#n372
>
> Can't we instead have reference to HW manual or datasheet?
> >
> > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@...e.fr>
> > ---
> >  .../devicetree/bindings/phy/qcom-qmp-phy.txt  |   5 +
> >  drivers/phy/qualcomm/phy-qcom-qmp.c           | 110 ++++++++++++++++++
> >  drivers/phy/qualcomm/phy-qcom-qmp.h           |  12 ++
> >  3 files changed, 127 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
> > index 5d181fc3cc18..6000ae34b12b 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
> > +++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
> > @@ -11,6 +11,7 @@ Required properties:
> >              "qcom,msm8996-qmp-usb3-phy" for 14nm USB3 phy on msm8996,
> >              "qcom,msm8998-qmp-usb3-phy" for USB3 QMP V3 phy on msm8998,
> >              "qcom,msm8998-qmp-ufs-phy" for UFS QMP phy on msm8998,
> > +            "qcom,msm8998-qmp-pcie-phy" for PCIe QMP phy on msm8998,
> >              "qcom,sdm845-qmp-usb3-phy" for USB3 QMP V3 phy on sdm845,
> >              "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on sdm845,
> >              "qcom,sdm845-qmp-ufs-phy" for UFS QMP phy on sdm845.
> > @@ -48,6 +49,8 @@ Required properties:
> >                       "aux", "cfg_ahb", "ref".
> >               For "qcom,msm8998-qmp-ufs-phy" must contain:
> >                       "ref", "ref_aux".
> > +             For "qcom,msm8998-qmp-pcie-phy" must contain:
> > +                     "aux", "cfg_ahb", "ref".
> >               For "qcom,sdm845-qmp-usb3-phy" must contain:
> >                       "aux", "cfg_ahb", "ref", "com_aux".
> >               For "qcom,sdm845-qmp-usb3-uni-phy" must contain:
> > @@ -70,6 +73,8 @@ Required properties:
> >               For "qcom,msm8998-qmp-usb3-phy" must contain
> >                       "phy", "common".
> >               For "qcom,msm8998-qmp-ufs-phy": no resets are listed.
> > +             For "qcom,msm8998-qmp-pcie-phy" must contain:
> > +                     "phy", "common", "cfg".
> >               For "qcom,sdm845-qmp-usb3-phy" must contain:
> >                       "phy", "common".
> >               For "qcom,sdm845-qmp-usb3-uni-phy" must contain:
>
> Please send the dt binding in a separate patch.
>
> Thanks
> Kishon

Thanks for the patch. Besides above comments from Kishon it looks good.
Reviewed-by: Vivek Gautam <vivek.gautam@...eaurora.org>

Best regards
Vivek

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation