lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 26 Mar 2019 09:55:00 +0100
From:   Pierre Yves MORDRET <pierre-yves.mordret@...com>
To:     Vinod Koul <vkoul@...nel.org>
CC:     Dan Williams <dan.j.williams@...el.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        <dmaengine@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] dmaengine: stm32-mdma: Revert "Add a check on
 read_u32_array"



On 3/25/19 5:28 PM, Vinod Koul wrote:
> On 25-03-19, 17:21, Pierre-Yves MORDRET wrote:
>> This reverts commit 906b40b246b0 ("Add a check on read_u32_array")
> 
> This and patch title should contain:
> 906b40b246b0 ("dmaengine: stm32-mdma: Add a check on read_u32_array")
> 
> I have fixed it up and applied.

Darn it, sorry.
Many thanks btw :)

> 
> Thanks
> 
>> As stated by bindings "st,ahb-addr-masks" is optional.
>> The statement inserted by this commit makes this property
>> mandatory and prevents MDMA to be probed in case property not present.
>>
>> Signed-off-by: Pierre-Yves MORDRET <pierre-yves.mordret@...com>
>> ---
>>   Version history:
>>     v2:
>>        * review commit message
>>     v1:
>>        * Initial
>> ---
>> ---
>>  drivers/dma/stm32-mdma.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c
>> index 4e0eede..ac0301b 100644
>> --- a/drivers/dma/stm32-mdma.c
>> +++ b/drivers/dma/stm32-mdma.c
>> @@ -1578,11 +1578,9 @@ static int stm32_mdma_probe(struct platform_device *pdev)
>>  
>>  	dmadev->nr_channels = nr_channels;
>>  	dmadev->nr_requests = nr_requests;
>> -	ret = device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks",
>> +	device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks",
>>  				       dmadev->ahb_addr_masks,
>>  				       count);
>> -	if (ret)
>> -		return ret;
>>  	dmadev->nr_ahb_addr_masks = count;
>>  
>>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> -- 
>> 2.7.4
> 

Powered by blists - more mailing lists