linux-kernel - Re: [PATCH v6] tty: 8250: fix a missing check for pci_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 Mar 2019 11:28:44 +0100
From:   Jiri Slaby <jslaby@...e.cz>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Aditya Pakki <pakki001@....edu>
Cc:     Vinod Koul <vkoul@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>, kjlu@....edu,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH v6] tty: 8250: fix a missing check for pci_ioremap_bar

On 26. 03. 19, 11:17, Andy Shevchenko wrote:
>> @@ -199,7 +203,10 @@ static void qrk_serial_exit_dma(struct lpss8250 *lpss)
>>  
>>  	if (!param->dma_dev)
>>  		return;
>> +
>>  	dw_dma_remove(&lpss->dma_chip);
>> +
>> +	iounmap(&lpss->dma_chip->regs);
> 
> This is a bit fragile form of writing. Perhaps

It actually won't even compile, will it (it must have been
"(&lpss->dma_chip)->regs")? Do you at least compile-test your patches
before sending?

thanks,
-- 
js
suse labs