linux-kernel - Re: [PATCH v2] x86/boot: Use EFI setup data if provided

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190326124611.GA8143@dhcp-128-65.nay.redhat.com>
Date:   Tue, 26 Mar 2019 20:46:11 +0800
From:   Dave Young <dyoung@...hat.com>
To:     Junichi Nomura <j-nomura@...jp.nec.com>
Cc:     Borislav Petkov <bp@...en8.de>,
        "fanc.fnst@...fujitsu.com" <fanc.fnst@...fujitsu.com>,
        "bhe@...hat.com" <bhe@...hat.com>,
        "kasong@...hat.com" <kasong@...hat.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "kexec@...ts.infradead.org" <kexec@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] x86/boot: Use EFI setup data if provided

On 03/25/19 at 11:10pm, Junichi Nomura wrote:
> On 3/25/19 9:32 PM, Borislav Petkov wrote:
> > On Mon, Mar 25, 2019 at 08:23:02PM +0800, Dave Young wrote:
> >> Kexec saved the original physical addresses, and pass them to kexeced
> >> kernel via x86 setup_data, so  both the early parsing or efi init code
> >> need to get those physical values from setup_data.
> > 
> > So efi_get_rsdp_addr() needs to be refactored in such a way so that at
> > least the loop towards the end gets carved out into a separate function
> > - __efi_get_rsdp_addr() or so - which gets config_tables, nr_tables and
> > size as arguments and finds the RSDP address in the kexec-ed kernel.
> 
> Since we still need to read systab for nr_tables and do signature
> check to determine if it's 32bit or 64bit for kexec-ed kernel,
> everything except the address of config_tables are common between
> normal boot and kexec boot.

Hmm, the efi/kexec support only added for 64bit, so no need check 32bit for
kexec.

Thanks
Dave