linux-kernel - Re: [PATCH] drm/panel: otm8009a: no error msg if probe deferred

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6786083-2832-87bf-9e88-d78108cd05cf@st.com>
Date:   Tue, 26 Mar 2019 12:49:33 +0000
From:   Philippe CORNU <philippe.cornu@...com>
To:     Yannick FERTRE <yannick.fertre@...com>,
        Thierry Reding <thierry.reding@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH] drm/panel: otm8009a: no error msg if probe deferred

Dear Yannick,
Many thanks for your patch.

Reviewed-by: Philippe Cornu <philippe.cornu@...com>
Tested-by: Philippe Cornu <philippe.cornu@...com>

Philippe :-)


On 3/21/19 9:04 AM, Yannick Fertré wrote:
> Do not print an error message if the regulator framework
> returns EPROBE_DEFER.
> 
> Signed-off-by: Yannick Fertré <yannick.fertre@...com>
> ---
>   drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> index 87fa316..aa3db38 100644
> --- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> +++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> @@ -433,7 +433,8 @@ static int otm8009a_probe(struct mipi_dsi_device *dsi)
>   	ctx->supply = devm_regulator_get(dev, "power");
>   	if (IS_ERR(ctx->supply)) {
>   		ret = PTR_ERR(ctx->supply);
> -		dev_err(dev, "failed to request regulator: %d\n", ret);
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(dev, "failed to request regulator: %d\n", ret);
>   		return ret;
>   	}
>   
>