linux-kernel - RE: [PATCH v4 6/6] dt-bindings: fpga: Add bindings for ZynqMP fpga driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SN6PR02MB47194C1EEA9BDD8F3FE61B75C25F0@SN6PR02MB4719.namprd02.prod.outlook.com>
Date:   Tue, 26 Mar 2019 14:06:15 +0000
From:   Nava kishore Manne <navam@...inx.com>
To:     Rob Herring <robh@...nel.org>
CC:     "atull@...nel.org" <atull@...nel.org>,
        "mdf@...nel.org" <mdf@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        Michal Simek <michals@...inx.com>,
        Rajan Vaja <RAJANV@...inx.com>, Jolly Shah <JOLLYS@...inx.com>,
        "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "chinnikishore369@...il.com" <chinnikishore369@...il.com>
Subject: RE: [PATCH v4 6/6] dt-bindings: fpga: Add bindings for ZynqMP fpga
 driver

Hi Rob,

	Thanks for the response.
Please find my response inline.

> -----Original Message-----
> From: Rob Herring [mailto:robh@...nel.org]
> Sent: Tuesday, March 26, 2019 12:49 AM
> To: Nava kishore Manne <navam@...inx.com>
> Cc: atull@...nel.org; mdf@...nel.org; mark.rutland@....com; Michal Simek
> <michals@...inx.com>; Rajan Vaja <RAJANV@...inx.com>; Jolly Shah
> <JOLLYS@...inx.com>; linux-fpga@...r.kernel.org; devicetree@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> chinnikishore369@...il.com
> Subject: Re: [PATCH v4 6/6] dt-bindings: fpga: Add bindings for ZynqMP fpga
> driver
> 
> On Thu, Mar 14, 2019 at 07:31:22PM +0530, Nava kishore Manne wrote:
> > Add documentation to describe Xilinx ZynqMP fpga driver bindings.
> >
> > Signed-off-by: Nava kishore Manne <nava.manne@...inx.com>
> > ---
> > Changes for v4:
> > 		-Modified binding description as suggested by Moritz Fischer.
> > Changes for v3:
> >                 -Removed PCAP as a child node to the FW and Created
> > 		 an independent node since PCAP driver is a consumer
> > 		 not a provider.
> 
> Huh?
> 
> It was the fpga-regions that I suggested should perhaps be at the top-level. As
> long as pcap is a function exposed by the firmware it should be a child of it.
> 
Thanks for providing the clarification. Will address the above comments in the next version.

Regards,
Navakishore.