linux-kernel - RE: [PATCH] scsi: ufs: Check for return value of create_singlethread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SN6PR04MB4925D262CF042EAE14E38F59FC5F0@SN6PR04MB4925.namprd04.prod.outlook.com>
Date:   Tue, 26 Mar 2019 14:46:45 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Aditya Pakki <pakki001@....edu>
CC:     "kjlu@....edu" <kjlu@....edu>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Pedro Sousa <pedrom.sousa@...opsys.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Subhash Jadavani <subhashj@...eaurora.org>,
        Asutosh Das <asutoshd@...eaurora.org>,
        Marc Gonzalez <marc.w.gonzalez@...e.fr>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Ohad Sharabi <ohad.sharabi@....com>,
        Vivek Gautam <vivek.gautam@...eaurora.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scsi: ufs: Check for return value of
 create_singlethread_workqueue

HI,
> 
> In case create_singlethread_workqueue fails in ufshcd_init_scaling, the
> patch returns the error upstream.
> 
> Signed-off-by: Aditya Pakki <pakki001@....edu>
> ---


>  out_remove_scsi_host:
>  	scsi_remove_host(hba->host);
> -exit_gating:
> +exit_scaling:
>  	ufshcd_exit_clk_scaling(hba);
> +exit_gating:
>  	ufshcd_exit_clk_gating(hba);
There are calls to exit_gating which expects clk_scaling cleanup as well.

Thanks,
Avri

>  out_disable:
>  	hba->is_irq_enabled = false;
> --
> 2.17.1