linux-kernel - Re: [PATCH net-next v5 07/22] ethtool: netlink bitset handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190326155911.GA4958@nanopsycho.orion>
Date:   Tue, 26 Mar 2019 16:59:11 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        John Linville <linville@...driver.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5 07/22] ethtool: netlink bitset handling

Mon, Mar 25, 2019 at 06:08:15PM CET, mkubecek@...e.cz wrote:
>Declare attribute type constants and add helper functions to generate and
>parse arbitrary length bit sets.

Hmm, this looks like a lot of work. Two things:
1) This is generic. Not really related to ethtool in any way. Could this
   be done in netlink common code?
2) Did you think about leveraging NLA_BITFIELD32? What I mean is this:
NEST_START
   NLA_BITFIELD32 index 0 (bit 0-31)
   NLA_BITFIELD32 index 1 (bit 32-63)
   NLA_BITFIELD32 index 2 (bit 64-95)
   NLA_BITFIELD32 index 3 (bit 96-127)
   ....
NEST_END
It is basically an array of NLA_BITFIELD32.