linux-kernel - Re: [PATCH AUTOSEL 5.0 116/262] mwifiex: don't advertise IBSS features without FW support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+ASDXM751is4yQvH=2Ti=YJH7Za6SzswZQ5k7bEV4PnqQQmqQ@mail.gmail.com>
Date:   Wed, 27 Mar 2019 11:08:43 -0700
From:   Brian Norris <briannorris@...omium.org>
To:     Sasha Levin <sashal@...nel.org>
Cc:     Linux Kernel <linux-kernel@...r.kernel.org>,
        stable <stable@...r.kernel.org>,
        Kalle Valo <kvalo@...eaurora.org>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        "<netdev@...r.kernel.org>" <netdev@...r.kernel.org>
Subject: Re: [PATCH AUTOSEL 5.0 116/262] mwifiex: don't advertise IBSS
 features without FW support

On Wed, Mar 27, 2019 at 11:05 AM Sasha Levin <sashal@...nel.org> wrote:
>
> From: Brian Norris <briannorris@...omium.org>
>
> [ Upstream commit 6f21ab30469d670de620f758330aca9f3433f693 ]
>
> As it is, doing something like
>
>   # iw phy phy0 interface add foobar type ibss
>
> on a firmware that doesn't have ad-hoc support just yields failures of
> HostCmd_CMD_SET_BSS_MODE, which happened to return a '-1' error code
> (-EPERM? not really right...) and sometimes may even crash the firmware
> along the way.
>
> Let's parse the firmware capability flag while registering the wiphy, so
> we don't allow attempting IBSS at all, and we get a proper -EOPNOTSUPP
> from nl80211 instead.
>
> Fixes: e267e71e68ae ("mwifiex: Disable adhoc feature based on firmware capability")
> Signed-off-by: Brian Norris <briannorris@...omium.org>
> Signed-off-by: Kalle Valo <kvalo@...eaurora.org>
> Signed-off-by: Sasha Levin <sashal@...nel.org>

The backport seems valid and useful:

Reviewed-by: Brian Norris <briannorris@...omium.org>