lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Mar 2019 22:45:39 -0500 From: Parav Pandit <parav@...lanox.com> To: kvm@...r.kernel.org, linux-kernel@...r.kernel.org, kwankhede@...dia.com, alex.williamson@...hat.com Cc: cjia@...dia.com, parav@...lanox.com Subject: [PATCHv1 1/7] vfio/mdev: Avoid release parent reference during error path During mdev parent registration in mdev_register_device(), if parent device is duplicate, it releases the reference of existing parent device. This is incorrect. Existing parent device should not be touched. Fixes: 7b96953bc640 ("vfio: Mediated device Core driver") Reviewed By: Kirti Wankhede <kwankhede@...dia.com> Reviewed-by: Maxim Levitsky <mlevitsk@...hat.com> Signed-off-by: Parav Pandit <parav@...lanox.com> --- drivers/vfio/mdev/mdev_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c index b96fedc..1299d2e 100644 --- a/drivers/vfio/mdev/mdev_core.c +++ b/drivers/vfio/mdev/mdev_core.c @@ -181,6 +181,7 @@ int mdev_register_device(struct device *dev, const struct mdev_parent_ops *ops) /* Check for duplicate */ parent = __find_parent_device(dev); if (parent) { + parent = NULL; ret = -EEXIST; goto add_dev_err; } -- 1.8.3.1
Powered by blists - more mailing lists