linux-kernel - Re: [PATCH] parport_cs: Fix memory leak in parport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20190327163423.GA2969@kroah.com>
Date:   Thu, 28 Mar 2019 01:34:23 +0900
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Mukesh Ojha <mojha@...eaurora.org>
Cc:     Yue Haibing <yuehaibing@...wei.com>, sudipm.mukherjee@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] parport_cs: Fix memory leak in parport_config

On Fri, Mar 22, 2019 at 05:39:17PM +0530, Mukesh Ojha wrote:
> 
> On 3/21/2019 1:56 PM, Yue Haibing wrote:
> > From: YueHaibing <yuehaibing@...wei.com>
> > 
> > parport_probe() alloc parport device 'info',
> > but while parport_config failed it does not free it.
> > 
> > Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> > ---
> >   drivers/parport/parport_cs.c | 5 +++--
> >   1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/parport/parport_cs.c b/drivers/parport/parport_cs.c
> > index e9b52e4..e77044c2 100644
> > --- a/drivers/parport/parport_cs.c
> > +++ b/drivers/parport/parport_cs.c
> > @@ -158,8 +158,9 @@ static int parport_config(struct pcmcia_device *link)
> >       return 0;
> >   failed:
> > -    parport_cs_release(link);
> > -    return -ENODEV;
> > +	parport_cs_release(link);
> > +	kfree(link->priv);
> > +	return -ENODEV;
> >   } /* parport_config */
> >   static void parport_cs_release(struct pcmcia_device *link)
> 
> 
> Reviewed-by: Mukesh Ojha <mojha@...eaurora.org
> <mailto:mojha@...eaurora.org>>

Please do not send html email for kernel patches :(