lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 27 Mar 2019 14:24:56 -0400 From: Sasha Levin <sashal@...nel.org> To: linux-kernel@...r.kernel.org, stable@...r.kernel.org Cc: Wen Yang <yellowriver2010@...mail.com>, Timur Tabi <timur@...nel.org>, Nicolin Chen <nicoleotsuka@...il.com>, Xiubo Li <Xiubo.Lee@...il.com>, Fabio Estevam <festevam@...il.com>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, NXP Linux Team <linux-imx@....com>, alsa-devel@...a-project.org, linuxppc-dev@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org, Sasha Levin <sashal@...nel.org> Subject: [PATCH AUTOSEL 3.18 19/41] SoC: imx-sgtl5000: add missing put_device() From: Wen Yang <yellowriver2010@...mail.com> [ Upstream commit 8fa857da9744f513036df1c43ab57f338941ae7d ] The of_find_device_by_node() takes a reference to the underlying device structure, we should release that reference. Detected by coccinelle with the following warnings: ./sound/soc/fsl/imx-sgtl5000.c:169:1-7: ERROR: missing put_device; call of_find_device_by_node on line 105, but without a corresponding object release within this function. ./sound/soc/fsl/imx-sgtl5000.c:177:1-7: ERROR: missing put_device; call of_find_device_by_node on line 105, but without a corresponding object release within this function. Signed-off-by: Wen Yang <yellowriver2010@...mail.com> Cc: Timur Tabi <timur@...nel.org> Cc: Nicolin Chen <nicoleotsuka@...il.com> Cc: Xiubo Li <Xiubo.Lee@...il.com> Cc: Fabio Estevam <festevam@...il.com> Cc: Liam Girdwood <lgirdwood@...il.com> Cc: Mark Brown <broonie@...nel.org> Cc: Jaroslav Kysela <perex@...ex.cz> Cc: Takashi Iwai <tiwai@...e.com> Cc: Shawn Guo <shawnguo@...nel.org> Cc: Sascha Hauer <s.hauer@...gutronix.de> Cc: Pengutronix Kernel Team <kernel@...gutronix.de> Cc: NXP Linux Team <linux-imx@....com> Cc: alsa-devel@...a-project.org Cc: linuxppc-dev@...ts.ozlabs.org Cc: linux-arm-kernel@...ts.infradead.org Cc: linux-kernel@...r.kernel.org Signed-off-by: Mark Brown <broonie@...nel.org> Signed-off-by: Sasha Levin <sashal@...nel.org> --- sound/soc/fsl/imx-sgtl5000.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c index 1cb22dd034eb..110f3cf361af 100644 --- a/sound/soc/fsl/imx-sgtl5000.c +++ b/sound/soc/fsl/imx-sgtl5000.c @@ -115,6 +115,7 @@ static int imx_sgtl5000_probe(struct platform_device *pdev) ret = -EPROBE_DEFER; goto fail; } + put_device(&ssi_pdev->dev); codec_dev = of_find_i2c_device_by_node(codec_np); if (!codec_dev) { dev_err(&pdev->dev, "failed to find codec platform device\n"); -- 2.19.1
Powered by blists - more mailing lists