lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 27 Mar 2019 14:02:39 +0900 From: William Breathitt Gray <vilhelm.gray@...il.com> To: linus.walleij@...aro.org, bgolaszewski@...libre.com Cc: akpm@...ux-foundation.org, linux-gpio@...r.kernel.org, linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org, andriy.shevchenko@...ux.intel.com, linux@...musvillemoes.dk, yamada.masahiro@...ionext.com, linux-arm-kernel@...ts.infradead.org, linux-pm@...r.kernel.org, geert@...ux-m68k.org, preid@...ctromag.com.au, William Breathitt Gray <vilhelm.gray@...il.com>, Geert Uytterhoeven <geert+renesas@...der.be> Subject: [PATCH v13 10/11] gpio: 74x164: Utilize the for_each_set_clump8 macro Replace verbose implementation in set_multiple callback with for_each_set_clump8 macro to simplify code and improve clarity. Suggested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Cc: Geert Uytterhoeven <geert+renesas@...der.be> Cc: Phil Reid <preid@...ctromag.com.au> Signed-off-by: William Breathitt Gray <vilhelm.gray@...il.com> --- drivers/gpio/gpio-74x164.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpio/gpio-74x164.c b/drivers/gpio/gpio-74x164.c index fb7b620763a2..0bbf1162bb31 100644 --- a/drivers/gpio/gpio-74x164.c +++ b/drivers/gpio/gpio-74x164.c @@ -9,6 +9,7 @@ * published by the Free Software Foundation. */ +#include <linux/bitops.h> #include <linux/init.h> #include <linux/mutex.h> #include <linux/spi/spi.h> @@ -75,20 +76,18 @@ static void gen_74x164_set_multiple(struct gpio_chip *gc, unsigned long *mask, unsigned long *bits) { struct gen_74x164_chip *chip = gpiochip_get_data(gc); - unsigned int i, idx, shift; - u8 bank, bankmask; + unsigned long offset; + unsigned long bankmask; + size_t bank; + unsigned long bitmask; mutex_lock(&chip->lock); - for (i = 0, bank = chip->registers - 1; i < chip->registers; - i++, bank--) { - idx = i / sizeof(*mask); - shift = i % sizeof(*mask) * BITS_PER_BYTE; - bankmask = mask[idx] >> shift; - if (!bankmask) - continue; + for_each_set_clump8(offset, bankmask, mask, chip->registers * 8) { + bank = (chip->registers - 1) - (offset / 8); + bitmask = bitmap_get_value8(bits, offset) & bankmask; chip->buffer[bank] &= ~bankmask; - chip->buffer[bank] |= bankmask & (bits[idx] >> shift); + chip->buffer[bank] |= bitmask; } __gen_74x164_write_config(chip); mutex_unlock(&chip->lock); -- 2.21.0
Powered by blists - more mailing lists