linux-kernel - Re: [PATCH tip/core/rcu 1/2] doc/kprobes: Update obsolete RCU update functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190327202217.GH4102@linux.ibm.com>
Date:   Wed, 27 Mar 2019 13:22:17 -0700
From:   "Paul E. McKenney" <paulmck@...ux.ibm.com>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     rcu@...r.kernel.org, linux-kernel@...r.kernel.org,
        mingo@...nel.org, jiangshanlai@...il.com, dipankar@...ibm.com,
        akpm@...ux-foundation.org, mathieu.desnoyers@...icios.com,
        josh@...htriplett.org, tglx@...utronix.de, peterz@...radead.org,
        rostedt@...dmis.org, dhowells@...hat.com, edumazet@...gle.com,
        fweisbec@...il.com, oleg@...hat.com, joel@...lfernandes.org,
        "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>,
        Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org
Subject: Re: [PATCH tip/core/rcu 1/2] doc/kprobes: Update obsolete RCU update
 functions

On Wed, Mar 27, 2019 at 12:21:12PM +0900, Masami Hiramatsu wrote:
> On Tue, 26 Mar 2019 16:00:49 -0700
> "Paul E. McKenney" <paulmck@...ux.ibm.com> wrote:
> 
> > The RCU flavors have been consolidated, so this commit replaces mentions
> > of the now-obsolete synchronize_sched() function with synchronize_rcu().
> 
> Thank you for updating!
> 
> Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Applied, thank you!

							Thanx, Paul

> > Signed-off-by: Paul E. McKenney <paulmck@...ux.ibm.com>
> > Cc: "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>
> > Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: Masami Hiramatsu <mhiramat@...nel.org>
> > Cc: Jonathan Corbet <corbet@....net>
> > Cc: <linux-doc@...r.kernel.org>
> > ---
> >  Documentation/kprobes.txt | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/kprobes.txt b/Documentation/kprobes.txt
> > index 10f4499e677c..ee60e519438a 100644
> > --- a/Documentation/kprobes.txt
> > +++ b/Documentation/kprobes.txt
> > @@ -243,10 +243,10 @@ Optimization
> >  ^^^^^^^^^^^^
> >  
> >  The Kprobe-optimizer doesn't insert the jump instruction immediately;
> > -rather, it calls synchronize_sched() for safety first, because it's
> > +rather, it calls synchronize_rcu() for safety first, because it's
> >  possible for a CPU to be interrupted in the middle of executing the
> > -optimized region [3]_.  As you know, synchronize_sched() can ensure
> > -that all interruptions that were active when synchronize_sched()
> > +optimized region [3]_.  As you know, synchronize_rcu() can ensure
> > +that all interruptions that were active when synchronize_rcu()
> >  was called are done, but only if CONFIG_PREEMPT=n.  So, this version
> >  of kprobe optimization supports only kernels with CONFIG_PREEMPT=n [4]_.
> >  
> > -- 
> > 2.17.1
> > 
> 
> 
> -- 
> Masami Hiramatsu <mhiramat@...nel.org>
>