linux-kernel - Re: [PATCH] MIPS: KGDB: fix kgdb support for SMP platforms.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=Unvv6qNyx-1A_5KUOr-PxjuctaAf5e+Ea0tpJ1c17vKg@mail.gmail.com>
Date:   Wed, 27 Mar 2019 16:15:23 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Chong Qiao <qiaochong@...ngson.cn>
Cc:     Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <paul.burton@...s.com>,
        James Hogan <jhogan@...nel.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Will Deacon <will.deacon@....com>,
        Christophe Leroy <christophe.leroy@....fr>,
        linux-mips@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] MIPS: KGDB: fix kgdb support for SMP platforms.

Hi,

On Wed, Mar 27, 2019 at 4:08 PM Chong Qiao <qiaochong@...ngson.cn> wrote:
>
> KGDB_call_nmi_hook is called by other cpu through smp call.
> MIPS smp call is processed in ipi irq handler and regs is saved in
>  handle_int.
> So kgdb_call_nmi_hook get regs by get_irq_regs and regs will be passed
>  to kgdb_cpu_enter.
>
> Signed-off-by: Chong Qiao <qiaochong@...ngson.cn>

Since you didn't really change any content, you could have just
carried my previous review.  In any case I'll add my tag again:

Reviewed-by: Douglas Anderson <dianders@...omium.org>

I'd also note that it's nice if you version your patches and include
version history.  If you need help you might consider using patman to
help you send upstream patches.  See:

http://git.denx.de/?p=u-boot.git;a=blob;f=tools/patman/README

...never mind that it lives in the U-Boot tree--it's great for kernel work too.

Thanks for contributing to the kernel!  :-)

-Doug