linux-kernel - Re: [PATCH] staging: rtl8723bs: core: fix line over 80 characters warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Mar 2019 09:36:06 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Anirudh Rayabharam <anirudh.rayabharam@...il.com>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        hadess@...ess.net, hdegoede@...hat.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: core: fix line over 80 characters
 warning

On Tue, Mar 26, 2019 at 11:55:07PM +0530, Anirudh Rayabharam wrote:
> Shorten the expression by re-using the part that was already computed to

This confused me.  Better to phrase it like:

Shorten the expression by using the "psecuritypriv" pointer.

> fix the line over 80 characters warning reported by checkpatch.pl.
> 
> Signed-off-by: Anirudh Rayabharam <anirudh.rayabharam@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index 18fabf5ff44b..bc0230672457 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -2336,8 +2336,8 @@ void rtw_ap_restore_network(struct adapter *padapter)
>  			Update_RA_Entry(padapter, psta);
>  			/* pairwise key */
>  			/* per sta pairwise key and settings */
> -			if ((padapter->securitypriv.dot11PrivacyAlgrthm == _TKIP_) ||
> -				(padapter->securitypriv.dot11PrivacyAlgrthm == _AES_)) {
> +			if ((psecuritypriv->dot11PrivacyAlgrthm == _TKIP_) ||
> +				(psecuritypriv->dot11PrivacyAlgrthm == _AES_)) {

It's better to align it slightly different as well.  In the kernel we
would normally align the second condition to match the first one.

I probably would have gotten rid of the parenthesis as well.  I don't
like double parenthesis around == because I reserve that for =
assignment conditions.

			if (psecuritypriv->dot11PrivacyAlgrthm == _TKIP_ ||
			    psecuritypriv->dot11PrivacyAlgrthm == _AES_) {
				rtw_setstakey_cmd(padapter, psta, true, false);

When you're changing just a couple lines like this you can get away with
making multiple white space changes at the same time because the One
Thing that the patch does is "Clean up a Condition".  There is some
flexibility in the One thing Per Patch rule, but you have to sell it in
the right way.  The patch description would be:

  Checkpatch.pl complains that this line is over 80 characters.  We
  should use the "psecuritypriv" for consistency.  It's not aligned
  properly and there are too many parenthesis.

  This patch just cleans up a condition, it doesn't affect runtime.

regards,
dan carpenter