linux-kernel - Re: [PATCH] ARM: socfpga: Fix object reference leaks in socfpga_setup_ocram_self

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <36c310f4-e22d-42bb-4d8d-c1e41306ede2@codeaurora.org>
Date:   Wed, 27 Mar 2019 12:47:26 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Huang Zijiang <huang.zijiang@....com.cn>, dinguyen@...nel.org
Cc:     linux@...linux.org.uk, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, wang.yi59@....com.cn
Subject: Re: [PATCH] ARM: socfpga: Fix object reference leaks in
 socfpga_setup_ocram_self_refresh


On 3/27/2019 5:23 AM, Huang Zijiang wrote:
> The of_find_device_by_node() takes a reference to the underlying device
> structure, we should release that reference.
>
> Signed-off-by: Huang Zijiang <huang.zijiang@....com.cn>
> ---
>   arch/arm/mach-socfpga/pm.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-socfpga/pm.c b/arch/arm/mach-socfpga/pm.c
> index d486678..8d7ca14 100644
> --- a/arch/arm/mach-socfpga/pm.c
> +++ b/arch/arm/mach-socfpga/pm.c
> @@ -53,7 +53,7 @@ static int socfpga_setup_ocram_self_refresh(void)
>   	if (!pdev) {
>   		pr_warn("%s: failed to find ocram device!\n", __func__);
>   		ret = -ENODEV;
> -		goto put_node;
> +		goto fail;
>   	}
>   
>   	ocram_pool = gen_pool_get(&pdev->dev, NULL);
> @@ -94,6 +94,9 @@ static int socfpga_setup_ocram_self_refresh(void)
>   
>   put_node:
>   	of_node_put(np);
> +	put_device(&np->dev);
> +fail:
> +	of_node_put(np);


of_node_put is called twice for put_node label.

Thanks,
Mukesh


>   
>   	return ret;
>   }