linux-kernel - [RESEND PATCH] thermal: rcar_gen3_thermal: Fix init value of IRQCTL register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1553677398-7896-1-git-send-email-na-hoan@jinso.co.jp>
Date:   Wed, 27 Mar 2019 18:03:18 +0900
From:   Nguyen An Hoan <na-hoan@...so.co.jp>
To:     linux-renesas-soc@...r.kernel.org, geert+renesas@...der.be
Cc:     rui.zhang@...el.com, jslaby@...e.com,
        wsa+renesas@...g-engineering.com, edubezval@...il.com,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        kuninori.morimoto.gx@...esas.com, yoshihiro.shimoda.uh@...esas.com,
        h-inayoshi@...so.co.jp, nv-dung@...so.co.jp, na-hoan@...so.co.jp,
        cv-dong@...so.co.jp
Subject: [RESEND PATCH] thermal: rcar_gen3_thermal: Fix init value of IRQCTL register

From: Hoan Nguyen An <na-hoan@...so.co.jp>

Fix setting value for IRQCTL register. We are setting the last 6 bits
of (IRQCTL) to be 1 (0x3f), this is only suitable for H3ES1.*, according
to Hardware manual values 1 are "setting prohibited" for Gen3.

Signed-off-by: Hoan Nguyen An <na-hoan@...so.co.jp>
---
 drivers/thermal/rcar_gen3_thermal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c
index 88fa41c..2482795 100644
--- a/drivers/thermal/rcar_gen3_thermal.c
+++ b/drivers/thermal/rcar_gen3_thermal.c
@@ -307,7 +307,7 @@ static void rcar_gen3_thermal_init(struct rcar_gen3_thermal_tsc *tsc)
 
 	usleep_range(1000, 2000);
 
-	rcar_gen3_thermal_write(tsc, REG_GEN3_IRQCTL, 0x3F);
+	rcar_gen3_thermal_write(tsc, REG_GEN3_IRQCTL, 0);
 	rcar_gen3_thermal_write(tsc, REG_GEN3_IRQMSK, 0);
 	rcar_gen3_thermal_write(tsc, REG_GEN3_IRQEN, IRQ_TEMPD1 | IRQ_TEMP2);
 
-- 
2.7.4