linux-kernel - Re: [PATCH v2 3/3] rcu: validate arguments for rcu tracepoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Mar 2019 09:17:45 +0800
From:   Yafang Shao <laoar.shao@...il.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     "Paul E. McKenney" <paulmck@...ux.ibm.com>, mingo@...hat.com,
        Peter Zijlstra <peterz@...radead.org>, josh@...htriplett.org,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        jiangshanlai@...il.com, joel@...lfernandes.org,
        LKML <linux-kernel@...r.kernel.org>, shaoyafang@...iglobal.com
Subject: Re: [PATCH v2 3/3] rcu: validate arguments for rcu tracepoints

On Tue, Mar 26, 2019 at 11:30 PM Steven Rostedt <rostedt@...dmis.org> wrote:
>
> On Tue, 26 Mar 2019 08:18:15 -0700
> "Paul E. McKenney" <paulmck@...ux.ibm.com> wrote:
>
> > On Tue, Mar 26, 2019 at 08:13:11PM +0800, Yafang Shao wrote:
> > > When CONFIG_RCU_TRACE is not set, all these tracepoints are defined as
> > > do-nothing macro.
> > > We'd better make those inline functions that take proper arguments.
> > >
> > > As RCU_TRACE() is defined as do-nothing marco as well when
> > > CONFIG_RCU_TRACE is not set, so we can clean it up.
> >
> > How about this for the commit log?
> >
> >       Unless the CONFIG_RCU_TRACE kconfig option is set, almost all
> >       of RCU's tracepoints are defined as empty macros.  It would
> >       be better if these tracepoints could instead be empty inline
> >       functions with proper arguments and type checking.  It would
> >       also be good to get rid of the RCU_TRACE() macro, which
> >       compiles its argument in CONFIG_RCU_TRACE=y kernels and
> >       omits them otherwise.
> >
> >       This commit therefore creates a TRACE_EVENT_RCU macro that
> >       is defined as TRACE_EVENT in CONFIG_RCU_TRACE=y kernels and
> >       as the new TRACE_EVENT_NOP otherwise, which allows the
> >       empty macros and the RCU_TRACE() macro to be eliminated.
> >
> > With that:
> >
> > Reviewed-by: Paul E. McKenney <paulmck@...ux.ibm.com>
>
> Yafang,
>
> If you are OK with the above changes, I'll take this patch with the
> updated change log.
>

Hi Steve,

This new changelog is OK by me.
Pls. take it.

Thanks
Yafang