linux-kernel - Re: [RFC PATCH] ceph: Convert to fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2235.1553681432@warthog.procyon.org.uk>
Date:   Wed, 27 Mar 2019 10:10:32 +0000
From:   David Howells <dhowells@...hat.com>
To:     "Yan, Zheng" <ukernel@...il.com>
Cc:     dhowells@...hat.com, ceph-devel <ceph-devel@...r.kernel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] ceph: Convert to fs_context

Yan, Zheng <ukernel@...il.com> wrote:

> > -       if (fsopt->sb_flags != other->mount_options->sb_flags) {
> > +       if (fc->sb_flags != sb->s_flags) {

Fixed with:

@@ -945,7 +945,7 @@ static int ceph_compare_super(struct super_block *sb, struct fs_context *fc)
 		dout("fsid doesn't match\n");
 		return 0;
 	}
-	if (fc->sb_flags != sb->s_flags) {
+	if (fc->sb_flags != (sb->s_flags & ~SB_BORN)) {
 		dout("flags differ\n");
 		return 0;
 	}

David