linux-kernel - Re: [PATCH v3] HID: core: move Usage Page concatenation to Main item

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3ea28268d51c6d9befecf273e1295ba11f8d3b06.camel@suse.de>
Date:   Wed, 27 Mar 2019 11:16:13 +0100
From:   Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
To:     Oliver Neukum <oneukum@...e.com>, Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:     Terry.Junge@...ntronics.com, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] HID: core: move Usage Page concatenation to Main item

Hi Oliver, thanks for the review!

On Wed, 2019-03-27 at 10:35 +0100, Oliver Neukum wrote:
> On Di, 2019-03-26 at 21:03 +0100, Nicolas Saenz Julienne wrote:
> > --- a/drivers/hid/hid-core.c
> > +++ b/drivers/hid/hid-core.c
> > @@ -218,13 +218,14 @@ static unsigned hid_lookup_collection(struct
> > hid_parser *parser, unsigned type)
> >   * Add a usage to the temporary parser table.
> >   */
> >  
> > -static int hid_add_usage(struct hid_parser *parser, unsigned usage)
> > +static int hid_add_usage(struct hid_parser *parser, unsigned usage, __u8
> > size)
> 
> No need to use the __u8 style inside the kernel. u8 will do.

Noted, fixed for v4.

> 
> 	Regards
> 		Oliver
> 


Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)