linux-kernel - Re: [PATCH v4 2/2] staging: mt7621-mmc: Initialize completions a single time during probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACmrr9iqK-g8o3tAAHD3NDy+9BiOkoXH+vFMT+stG37iZ2Zp5g@mail.gmail.com>
Date:   Tue, 26 Mar 2019 19:46:36 -0600
From:   George Hilliard <thirtythreeforty@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] staging: mt7621-mmc: Initialize completions a
 single time during probe

On Tue, Mar 26, 2019 at 6:46 PM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> On Tue, Mar 26, 2019 at 09:21:39AM -0600, George Hilliard wrote:
> > -     init_completion(&host->cmd_done);
> > +     // The completion should have been consumed by the previous command
> > +     // response handler, because the mmc requests should be serialized
> > +     if(completion_done(&host->cmd_done))
>
> Did you run your patch through checkpatch.pl?  It should have reported
> an error here :(

No, I didn't.  My mistake, sorry.  Will fix up and resend again.

George