linux-kernel - Re: [PATCH] platform/x86: intel_pmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4554bd3e-fabb-44aa-fc82-52ec9cbf9b2c@linux.intel.com>
Date:   Wed, 27 Mar 2019 18:16:54 +0530
From:   "Bhardwaj, Rajneesh" <rajneesh.bhardwaj@...ux.intel.com>
To:     Guenter Roeck <linux@...ck-us.net>,
        Rajneesh Bhardwaj <rajneesh.bhardwaj@...el.com>
Cc:     Vishwanath Somayaji <vishwanath.somayaji@...el.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: intel_pmc_core: Mark local function static


On 27-Mar-19 1:59 AM, Guenter Roeck wrote:
> 0day reports:
>
> drivers/platform/x86/intel_pmc_core.c:833:5: sparse:
> 	symbol 'quirk_xtal_ignore' was not declared. Should it be static?

Looks good to me.

> Mark the function static since it is indeed only called locally.
>
> Cc: Rajneesh Bhardwaj <rajneesh.bhardwaj@...ux.intel.com>
> Fixes: 238f9c11351f ("platform/x86: intel_pmc_core: Quirk to ignore XTAL shutdown")
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
>   drivers/platform/x86/intel_pmc_core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
> index f2c621b55f49..9908d233305e 100644
> --- a/drivers/platform/x86/intel_pmc_core.c
> +++ b/drivers/platform/x86/intel_pmc_core.c
> @@ -828,7 +828,7 @@ static const struct pci_device_id pmc_pci_ids[] = {
>    * the platform BIOS enforces 24Mhx Crystal to shutdown
>    * before PMC can assert SLP_S0#.
>    */
> -int quirk_xtal_ignore(const struct dmi_system_id *id)
> +static int quirk_xtal_ignore(const struct dmi_system_id *id)
>   {
>   	struct pmc_dev *pmcdev = &pmc;
>   	u32 value;