linux-kernel - Re: [PATCH] scsi: sun_esp: : Fix object reference leaks in esp_sbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8560b226-1f0b-e9c6-6a18-800e10111f65@codeaurora.org>
Date:   Wed, 27 Mar 2019 18:17:34 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Huang Zijiang <huang.zijiang@....com.cn>, jejb@...ux.ibm.com
Cc:     martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, wang.yi59@....com.cn
Subject: Re: [PATCH] scsi: sun_esp: : Fix object reference leaks in
 esp_sbus_probe


Sorry for the spam whosoever has got the last mail, as the last did not 
get to
the mailing list, and it bounced, so sending it again.

On 3/27/2019 5:25 AM, Huang Zijiang wrote:
> The of_find_device_by_node() takes a reference to the underlying device
> structure, we should release that reference whatever of_find_device_by_node
> reutrns.
s/reutrns/returns
>
> Signed-off-by: Huang Zijiang <huang.zijiang@....com.cn>



Take mine review tag once you make above change.

Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

-Mukesh



> ---
>   drivers/scsi/sun_esp.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/sun_esp.c b/drivers/scsi/sun_esp.c
> index a11efbc..a74605a 100644
> --- a/drivers/scsi/sun_esp.c
> +++ b/drivers/scsi/sun_esp.c
> @@ -543,9 +543,8 @@ static int esp_sbus_probe(struct platform_device *op)
>   		return -ENODEV;
>   
>   	ret = esp_sbus_probe_one(op, dma_of, hme);
> -	if (ret)
> -		put_device(&dma_of->dev);
>   
> +	put_device(&dma_of->dev);
>   	return ret;
>   }
>