linux-kernel - Re: [PATCH] infiniband: cxgb4: fix a potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190327133728.GA26660@chelsio.com>
Date:   Wed, 27 Mar 2019 19:08:54 +0530
From:   Potnuri Bharat Teja <bharat@...lsio.com>
To:     Kangjie Lu <kjlu@....edu>
Cc:     "pakki001@....edu" <pakki001@....edu>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] infiniband: cxgb4: fix a potential NULL pointer
 dereference

On Saturday, March 03/23/19, 2019 at 08:07:46 +0530, Kangjie Lu wrote:
> 
> 
> > On Mar 8, 2019, at 11:19 PM, Kangjie Lu <kjlu@....edu> wrote:
> > 
> > get_skb may fail and return NULL. The fix returns "ENOMEM"
> > when it fails to avoid NULL dereference.
> > 
> > Signed-off-by: Kangjie Lu <kjlu@....edu>
> > ---
> > drivers/infiniband/hw/cxgb4/cm.c | 3 +++
> > 1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
> > index 8221813219e5..502a54d57e2c 100644
> > --- a/drivers/infiniband/hw/cxgb4/cm.c
> > +++ b/drivers/infiniband/hw/cxgb4/cm.c
> > @@ -1919,6 +1919,9 @@ static int send_fw_act_open_req(struct c4iw_ep *ep, unsigned int atid)
> > 	int win;
> > 
> > 	skb = get_skb(NULL, sizeof(*req), GFP_KERNEL);
> > +	if (!skb)
> > +		return -ENOMEM;
> > +
> 
> Can someone review this patch? Thanks.

Sorry for the late response.
I recommend an error print before the return.
---
if (!skb) {
	pr_err("%s - failed to alloc skb\n", __func__);
	return -ENOMEM;
}
---
Thanks for the patch!
- Bharat.
> 
> > 	req = __skb_put_zero(skb, sizeof(*req));
> > 	req->op_compl = htonl(WR_OP_V(FW_OFLD_CONNECTION_WR));
> > 	req->len16_pkd = htonl(FW_WR_LEN16_V(DIV_ROUND_UP(sizeof(*req), 16)));
> > -- 
> > 2.17.1
> > 
>