linux-kernel - Re: [PATCH] RISC-V: Implement ASID allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4dca2cfe-069f-f458-b1a7-f87aa6718ef7@garyguo.net>
Date:   Wed, 27 Mar 2019 14:09:15 +0000
From:   Gary Guo <gary@...yguo.net>
To:     Anup Patel <anup@...infault.org>
CC:     Anup Patel <Anup.Patel@....com>,
        Palmer Dabbelt <palmer@...ive.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Atish Patra <Atish.Patra@....com>,
        Christoph Hellwig <hch@...radead.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] RISC-V: Implement ASID allocator

I think my code already get all the caveats cases covered. The only 
thing my code is missing is handling the case when ASID is not 
supported. Maybe it is better to work based on that instead?

On 27/03/2019 14:02, Anup Patel wrote:
> On Wed, Mar 27, 2019 at 7:12 PM Gary Guo <gary@...yguo.net> wrote:
>>
>> I would also like to mention that your code assumes 64-bit atomics
>> support which we don't have on 32-bit systems. Using 32-bit to track
>> ASID generations isn't sufficient and will cause overflows. That's why I
>> have asid_generation_overflow to handle the case (this is super
>> error-prone as well).
> 
> Thanks for catching. I will fix issues with 32bit systems and send v2
> soon.
> 
> Regards,
> Anup
>