linux-kernel - Re: [PATCH] jbd2: remove repeated assignments in __jbd2_log_wait_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20190327162535.GA6742@quack2.suse.cz>
Date:   Wed, 27 Mar 2019 17:25:35 +0100
From:   Jan Kara <jack@...e.cz>
To:     Liu Song <fishland@...yun.com>
Cc:     tytso@....edu, jack@...e.com, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org, liu.song11@....com.cn
Subject: Re: [PATCH] jbd2: remove repeated assignments in
 __jbd2_log_wait_for_space

On Wed 27-03-19 22:31:35, Liu Song wrote:
> From: Liu Song <liu.song11@....com.cn>
> 
> At the beginning, nblocks has been assigned. There is no need
> to repeat the assignment in the while loop, and remove it.
> 
> Signed-off-by: Liu Song <liu.song11@....com.cn>

Looks good. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/jbd2/checkpoint.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/jbd2/checkpoint.c b/fs/jbd2/checkpoint.c
> index 26f8d7e46462..23053de5e999 100644
> --- a/fs/jbd2/checkpoint.c
> +++ b/fs/jbd2/checkpoint.c
> @@ -132,7 +132,6 @@ void __jbd2_log_wait_for_space(journal_t *journal)
>  			return;
>  		}
>  		spin_lock(&journal->j_list_lock);
> -		nblocks = jbd2_space_needed(journal);
>  		space_left = jbd2_log_space_left(journal);
>  		if (space_left < nblocks) {
>  			int chkpt = journal->j_checkpoint_transactions != NULL;
> -- 
> 2.19.1
> 
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR