linux-kernel - Re: [PATCH] x86/Xen: streamline (and fix) PV CPU enumeration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f027b4b-dce2-3e90-dc1b-c824bc8eb355@oracle.com>
Date:   Wed, 27 Mar 2019 13:07:19 -0400
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Jan Beulich <JBeulich@...e.com>,
        Stefano Stabellini <sstabellini@...nel.org>,
        Juergen Gross <jgross@...e.com>
Cc:     xen-devel <xen-devel@...ts.xenproject.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/Xen: streamline (and fix) PV CPU enumeration

On 3/27/19 11:12 AM, Jan Beulich wrote:
> -
> -static void __init xen_filter_cpu_maps(void)
> +static void __init _get_smp_config(unsigned int early)
>  {
>  	int i, rc;
>  	unsigned int subtract = 0;
>  
> -	if (!xen_initial_domain())
> +	if (early)
>  		return;
>  
>  	num_processors = 0;


Is there a reason to set_cpu_possible() here (not in the diff, but in
this routine)? This will be called from setup_arch() before
prefill_possible_map(), which will clear and then re-initialize
__cpu_possible_mask.



-boris