| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20190328055720.GB14864@rapoport-lnx>
Date: Thu, 28 Mar 2019 07:57:21 +0200
From: Mike Rapoport <rppt@...ux.ibm.com>
To: Sasha Levin <sashal@...nel.org>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
Catalin Marinas <catalin.marinas@....com>,
Christophe Leroy <christophe.leroy@....fr>,
Christoph Hellwig <hch@....de>,
"David S. Miller" <davem@...emloft.net>,
Dennis Zhou <dennis@...nel.org>,
Geert Uytterhoeven <geert@...ux-m68k.org>,
Greentime Hu <green.hu@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Guan Xuetao <gxt@....edu.cn>, Guo Ren <guoren@...nel.org>,
Guo Ren <ren_guo@...ky.com>,
Heiko Carstens <heiko.carstens@...ibm.com>,
Juergen Gross <jgross@...e.com>,
Mark Salter <msalter@...hat.com>,
Matt Turner <mattst88@...il.com>,
Max Filippov <jcmvbkbc@...il.com>,
Michal Simek <monstr@...str.eu>,
Paul Burton <paul.burton@...s.com>,
Petr Mladek <pmladek@...e.com>,
Richard Weinberger <richard@....at>,
Rich Felker <dalias@...c.org>,
Rob Herring <robh+dt@...nel.org>,
Rob Herring <robh@...nel.org>,
Russell King <linux@...linux.org.uk>,
Stafford Horne <shorne@...il.com>,
Tony Luck <tony.luck@...el.com>,
Vineet Gupta <vgupta@...opsys.com>,
Yoshinori Sato <ysato@...rs.sourceforge.jp>,
Andrew Morton <akpm@...ux-foundation.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
linuxppc-dev@...ts.ozlabs.org, linux-mm@...ck.org
Subject: Re: [PATCH AUTOSEL 5.0 015/262] memblock:
memblock_phys_alloc_try_nid(): don't panic
Hi,
On Wed, Mar 27, 2019 at 01:57:50PM -0400, Sasha Levin wrote:
> From: Mike Rapoport <rppt@...ux.ibm.com>
>
> [ Upstream commit 337555744e6e39dd1d87698c6084dd88a606d60a ]
>
> The memblock_phys_alloc_try_nid() function tries to allocate memory from
> the requested node and then falls back to allocation from any node in
> the system. The memblock_alloc_base() fallback used by this function
> panics if the allocation fails.
>
> Replace the memblock_alloc_base() fallback with the direct call to
> memblock_alloc_range_nid() and update the memblock_phys_alloc_try_nid()
> callers to check the returned value and panic in case of error.
This is a part of memblock refactoring, I don't think it should be applied
to -stable.
> Link: http://lkml.kernel.org/r/1548057848-15136-7-git-send-email-rppt@linux.ibm.com
> Signed-off-by: Mike Rapoport <rppt@...ux.ibm.com>
> Acked-by: Michael Ellerman <mpe@...erman.id.au> [powerpc]
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Christophe Leroy <christophe.leroy@....fr>
> Cc: Christoph Hellwig <hch@....de>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Dennis Zhou <dennis@...nel.org>
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Greentime Hu <green.hu@...il.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Guan Xuetao <gxt@....edu.cn>
> Cc: Guo Ren <guoren@...nel.org>
> Cc: Guo Ren <ren_guo@...ky.com> [c-sky]
> Cc: Heiko Carstens <heiko.carstens@...ibm.com>
> Cc: Juergen Gross <jgross@...e.com> [Xen]
> Cc: Mark Salter <msalter@...hat.com>
> Cc: Matt Turner <mattst88@...il.com>
> Cc: Max Filippov <jcmvbkbc@...il.com>
> Cc: Michal Simek <monstr@...str.eu>
> Cc: Paul Burton <paul.burton@...s.com>
> Cc: Petr Mladek <pmladek@...e.com>
> Cc: Richard Weinberger <richard@....at>
> Cc: Rich Felker <dalias@...c.org>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Rob Herring <robh@...nel.org>
> Cc: Russell King <linux@...linux.org.uk>
> Cc: Stafford Horne <shorne@...il.com>
> Cc: Tony Luck <tony.luck@...el.com>
> Cc: Vineet Gupta <vgupta@...opsys.com>
> Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
> arch/arm64/mm/numa.c | 4 ++++
> arch/powerpc/mm/numa.c | 4 ++++
> mm/memblock.c | 4 +++-
> 3 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c
> index ae34e3a1cef1..2c61ea4e290b 100644
> --- a/arch/arm64/mm/numa.c
> +++ b/arch/arm64/mm/numa.c
> @@ -237,6 +237,10 @@ static void __init setup_node_data(int nid, u64 start_pfn, u64 end_pfn)
> pr_info("Initmem setup node %d [<memory-less node>]\n", nid);
>
> nd_pa = memblock_phys_alloc_try_nid(nd_size, SMP_CACHE_BYTES, nid);
> + if (!nd_pa)
> + panic("Cannot allocate %zu bytes for node %d data\n",
> + nd_size, nid);
> +
> nd = __va(nd_pa);
>
> /* report and initialize */
> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
> index 87f0dd004295..8ec2ed30d44c 100644
> --- a/arch/powerpc/mm/numa.c
> +++ b/arch/powerpc/mm/numa.c
> @@ -788,6 +788,10 @@ static void __init setup_node_data(int nid, u64 start_pfn, u64 end_pfn)
> int tnid;
>
> nd_pa = memblock_phys_alloc_try_nid(nd_size, SMP_CACHE_BYTES, nid);
> + if (!nd_pa)
> + panic("Cannot allocate %zu bytes for node %d data\n",
> + nd_size, nid);
> +
> nd = __va(nd_pa);
>
> /* report and initialize */
> diff --git a/mm/memblock.c b/mm/memblock.c
> index ea31045ba704..d5923df56acc 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -1342,7 +1342,9 @@ phys_addr_t __init memblock_phys_alloc_try_nid(phys_addr_t size, phys_addr_t ali
>
> if (res)
> return res;
> - return memblock_alloc_base(size, align, MEMBLOCK_ALLOC_ACCESSIBLE);
> + return memblock_alloc_range_nid(size, align, 0,
> + MEMBLOCK_ALLOC_ACCESSIBLE,
> + NUMA_NO_NODE, MEMBLOCK_NONE);
> }
>
> /**
> --
> 2.19.1
>
--
Sincerely yours,
Mike.
Powered by blists - more mailing lists