linux-kernel - Re: [PATCH] arch:sparc:kernel/uprobes.c : Remove duplicate header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <636ab5b9-d0ba-d3df-3c1c-75f4b045c922@codeaurora.org>
Date:   Thu, 28 Mar 2019 12:05:51 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     jagdsh.linux@...il.com, davem@...emloft.net, paul.burton@...s.com
Cc:     sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch:sparc:kernel/uprobes.c : Remove duplicate header


On 3/28/2019 2:58 AM, jagdsh.linux@...il.com wrote:
> From: Jagadeesh Pagadala <jagdsh.linux@...il.com>
>
> Remove duplicate header which is included twice.
>
> Signed-off-by: Jagadeesh Pagadala <jagdsh.linux@...il.com>

Looks good to me. but did you tested at least the compilation with these 
patches ?

Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

-Mukesh


> ---
>   arch/sparc/kernel/uprobes.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/arch/sparc/kernel/uprobes.c b/arch/sparc/kernel/uprobes.c
> index d852ae5..c44bf5b 100644
> --- a/arch/sparc/kernel/uprobes.c
> +++ b/arch/sparc/kernel/uprobes.c
> @@ -29,7 +29,6 @@
>   #include <linux/kdebug.h>
>   
>   #include <asm/cacheflush.h>
> -#include <linux/uaccess.h>
>   
>   /* Compute the address of the breakpoint instruction and return it.
>    *