linux-kernel - Re: [PATCH net-next v5 16/22] ethtool: provide link settings and link modes in GET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190328100412.GD26076@unicorn.suse.cz>
Date:   Thu, 28 Mar 2019 11:04:12 +0100
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Jiri Pirko <jiri@...nulli.us>, Andrew Lunn <andrew@...n.ch>,
        John Linville <linville@...driver.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5 16/22] ethtool: provide link settings and
 link modes in GET_SETTINGS request

On Wed, Mar 27, 2019 at 08:44:58PM -0700, Florian Fainelli wrote:
> 
> 
> On 3/25/2019 10:08 AM, Michal Kubecek wrote:
> > Implement GET_SETTINGS netlink request to get link settings and link mode
> > information provided by ETHTOOL_GLINKSETTINGS ioctl command.
> > 
> > The information in SET_SETTINGS message sent as reply is divided into two
> > parts: autonegotiation, speed, duplex and supported, advertised and peer
> > advertised link modes when ETH_SETTINGS_IM_LINKMODES flag is set in the
> > request and other settings when ETH_SETTINGS_IM_LINKINFO is set.
> > 
> > Send notification in the same format as the reply message when relevant
> > fields are modified using the ioctl interface (ETHTOOL_SLINKSETTINGS or
> > ETHTOOL_SSET command).
> > 
> > Signed-off-by: Michal Kubecek <mkubecek@...e.cz>
> > ---
> 
> [snip]
> 
> > +    ETHA_SETTINGS_DEV		(nested)	device identification
> > +    ETHA_SETTINGS_LINK_INFO	(nested)	link settings
> > +        ETHA_LINKINFO_PORT		(u8)		physical port
> > +        ETHA_LINKINFO_PHYADDR		(u8)		MDIO address of phy
> > +        ETHA_LINKINFO_TP_MDIX		(u8)		MDI(-X) status
> > +        ETHA_LINKINFO_TP_MDIX_CTRL	(u8)		MDI(-X) control
> > +        ETHA_LINKINFO_TRANSCEIVER	(u8)		transceiver
> > +    ETHA_SETTINGS_LINK_MODES	(nested)	link modes
> > +        ETHA_LINKMODES_AUTONEG		(u8)		autoneotiation status
> 
> Typo: auto-negotiation status.

Will fix, thanks.

Michal