linux-kernel - Re: [PATCH] drivers/fmc: remove unneeded NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9a0194ef-2c45-3a29-2297-ee632779adb0@codeaurora.org>
Date:   Thu, 28 Mar 2019 15:52:39 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Ding Xiang <dingxiang@...s.chinamobile.com>, rubini@...dd.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/fmc: remove unneeded NULL check


On 3/28/2019 2:53 PM, Ding Xiang wrote:
> The variable will check in debugfs_remove_recursive, so
> the NULL check here is not needed
>
> Signed-off-by: Ding Xiang <dingxiang@...s.chinamobile.com>


Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

-Mukesh

> ---
>   drivers/fmc/fmc-debug.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/fmc/fmc-debug.c b/drivers/fmc/fmc-debug.c
> index 3293072..ab868a3 100644
> --- a/drivers/fmc/fmc-debug.c
> +++ b/drivers/fmc/fmc-debug.c
> @@ -168,6 +168,5 @@ int fmc_debug_init(struct fmc_device *fmc)
>   
>   void fmc_debug_exit(struct fmc_device *fmc)
>   {
> -	if (fmc->dbg_dir)
> -		debugfs_remove_recursive(fmc->dbg_dir);
> +	debugfs_remove_recursive(fmc->dbg_dir);
>   }