linux-kernel - Re: [PATCH 18/25] coresight: Introduce generic platform data helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5268e8bd-2c6d-72bd-7628-e7d5ff90b2da@arm.com>
Date:   Thu, 28 Mar 2019 10:59:57 +0000
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     mathieu.poirier@...aro.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-acpi@...r.kernel.org, coresight@...ts.linaro.org,
        mike.leach@...aro.org, robert.walker@....com
Subject: Re: [PATCH 18/25] coresight: Introduce generic platform data helper

On 03/27/2019 10:57 PM, Mathieu Poirier wrote:
> On Wed, Mar 20, 2019 at 06:49:35PM +0000, Suzuki K Poulose wrote:
>> So far we have hard coded the DT platform parsing code in
>> every driver. Introduce generic helper to parse the information
>> provided by the firmware in a platform agnostic manner, in preparation
>> for the ACPI support.
>>
>> Cc: Mathieu Poirier <mathieu.poirier@...aro.org>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@....com>


>>   
>> +static int coresight_alloc_conns(struct device *dev,
>> +				 struct coresight_platform_data *pdata)
>> +{
>> +	if (pdata->nr_outport) {
>> +		pdata->conns = devm_kzalloc(dev, pdata->nr_outport *
>> +					    sizeof(*pdata->conns),
>> +					    GFP_KERNEL);
>> +		if (!pdata->conns)
>> +			return -ENOMEM;
>> +	}
>> +
>> +	return 0;
>> +}
>> +

>> -	ret = of_coresight_alloc_memory(dev, pdata);
>> +	ret = coresight_alloc_conns(dev, pdata);
> 
> I'm pretty sure you're doing this because you want to use
> coresight_alloc_conns() for ACPI as well, and I'm fine with that.  But it is
> quite orthogonal to the rest of the work done in this patch and as such I think
> it needs a patch of its own.
> 

Sure, will split this into a separate patch.

Suzuki