linux-kernel - Re: [PATCH 13/25] coresight: etb10: Clean up device specific data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67c7b74e-62d9-1f73-0622-b861af44c6b4@arm.com>
Date:   Thu, 28 Mar 2019 11:09:12 +0000
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     mathieu.poirier@...aro.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-acpi@...r.kernel.org, coresight@...ts.linaro.org,
        mike.leach@...aro.org, robert.walker@....com
Subject: Re: [PATCH 13/25] coresight: etb10: Clean up device specific data

On 03/27/2019 09:39 PM, Mathieu Poirier wrote:
> On Wed, Mar 20, 2019 at 06:49:30PM +0000, Suzuki K Poulose wrote:
>> Track the coresight device instead of the real device.
>>
>> Cc: Mathieu Poirier <mathieu.poirier@...aro.org>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@....com>

>>   
>> @@ -701,7 +701,6 @@ static int etb_probe(struct amba_device *adev, const struct amba_id *id)
>>   	if (!drvdata)
>>   		return -ENOMEM;
>>   
>> -	drvdata->dev = &adev->dev;
>>   	drvdata->atclk = devm_clk_get(&adev->dev, "atclk"); /* optional */
>>   	if (!IS_ERR(drvdata->atclk)) {
>>   		ret = clk_prepare_enable(drvdata->atclk);
>> @@ -740,6 +739,7 @@ static int etb_probe(struct amba_device *adev, const struct amba_id *id)
>>   	if (IS_ERR(drvdata->csdev))
>>   		return PTR_ERR(drvdata->csdev);
>>   
>> +	drvdata->dev = &drvdata->csdev->dev;
> 
> For patch 11, 12, 13 - same comment as earlier.  Let's use drvdata::csdev
> and get rid of drvdata::dev.
> 

Sure, will do.

Thanks for the detailed review !

Suzuki