linux-kernel - Re: [PATCH v2 3/7] x86/boot: Split out parse_serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Mar 2019 15:15:57 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Borislav Petkov <bp@...en8.de>, Joe Perches <joe@...ches.com>
Cc:     "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/7] x86/boot: Split out parse_serial_port() helper
 for earlyprintk

On Thu, Mar 28, 2019 at 01:35:04PM +0100, Borislav Petkov wrote:
> On Tue, Mar 19, 2019 at 09:43:21PM +0300, Andy Shevchenko wrote:
> > The newly introduced helper will be used later on to parse serial port
> > in different type of earlyprintk command line arguments.
> > 
> > No functional change intended.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > ---
> >  arch/x86/boot/early_serial_console.c | 20 +++++++++++++++-----
> >  1 file changed, 15 insertions(+), 5 deletions(-)
> > 
> > diff --git a/arch/x86/boot/early_serial_console.c b/arch/x86/boot/early_serial_console.c
> > index 05d02cd4de99..85a227a21f95 100644
> > --- a/arch/x86/boot/early_serial_console.c
> > +++ b/arch/x86/boot/early_serial_console.c
> > @@ -66,6 +66,20 @@ static void early_serial_init(unsigned long port, int baud)
> >  	early_serial_base = port;
> >  }
> >  
> > +static unsigned long parse_serial_port(const char *arg, int off, int *pos)
> > +{
> > +	unsigned long port;
> > +	char *e;
> > +
> > +	port = simple_strtoull(arg + off, &e, 16);
> 
> WARNING: simple_strtoull is obsolete, use kstrtoull instead
> #41: FILE: arch/x86/boot/early_serial_console.c:74:
> +       port = simple_strtoull(arg + off, &e, 16);

kstrtox() simple can't cover _all_ simple_strtox() cases.

> Please do a conversion patch ontop.

I don't feel like uglifying code to satisfy a tool producing a silly warning.

-- 
With Best Regards,
Andy Shevchenko