lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Mar 2019 15:03:29 +0100 From: Borislav Petkov <bp@...en8.de> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Cc: Joe Perches <joe@...ches.com>, "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 3/7] x86/boot: Split out parse_serial_port() helper for earlyprintk On Thu, Mar 28, 2019 at 03:50:15PM +0200, Andy Shevchenko wrote: > Can, but with code uglifying to workaround kstrtox() restrictions. > simple_strtox() _just works_ as expected. simple_strtox() also has its problems. > Requires buffer copying, finding digits there, making a proper termination. And It needs a single kstrtoull() call to parse the port. And we have kstrtoull() available in the compressed stage so pls do the conversion ontop. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.
Powered by blists - more mailing lists