linux-kernel - Re: [PATCH v2 3/7] x86/boot: Split out parse_serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190328142302.GE9224@smile.fi.intel.com>
Date:   Thu, 28 Mar 2019 16:23:02 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Joe Perches <joe@...ches.com>, "H. Peter Anvin" <hpa@...or.com>,
        x86@...nel.org, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/7] x86/boot: Split out parse_serial_port() helper
 for earlyprintk

On Thu, Mar 28, 2019 at 03:03:29PM +0100, Borislav Petkov wrote:
> On Thu, Mar 28, 2019 at 03:50:15PM +0200, Andy Shevchenko wrote:
> > Can, but with code uglifying to workaround kstrtox() restrictions.
> > simple_strtox() _just works_ as expected.
> 
> simple_strtox() also has its problems.

Yes! And point here: we do not care.

> > Requires buffer copying, finding digits there, making a proper termination. And
> 
> It needs a single kstrtoull() call to parse the port. 

No, it does not. It needs more as I described. Have you investigated a topic?
Have you seen all possible combinations of input here?

> And we have
> kstrtoull() available in the compressed stage so pls do the conversion
> ontop.

If it's strong opinion, I consider this rather as NAK.
Thank you for review.

-- 
With Best Regards,
Andy Shevchenko