linux-kernel - Re: [PATCH 3/3] gpio: Remove obsolete comment about gpiochip_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff6d95d6-9022-4cab-bc53-bb9ffd14ed68@codeaurora.org>
Date:   Thu, 28 Mar 2019 20:31:48 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:     Benoit Parrot <bparrot@...com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        Tomeu Vizoso <tomeu.vizoso@...labora.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] gpio: Remove obsolete comment about
 gpiochip_free_hogs() usage


On 3/28/2019 6:43 PM, Geert Uytterhoeven wrote:
> gpiochip_free_hogs() was always called from gpiochip_remove(), not
> of_gpiochip_remove().  It is now also called from the failure patch in
> gpiochip_add_data_with_key().
>
> Fixes: f625d4601759f1cf ("gpio: add GPIO hogging mechanism")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>


Looks good to be removed.
Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

-Mukesh

> ---
>   drivers/gpio/gpiolib.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index ed4da07effe0ac40..ec326bd84b1f1c50 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -4449,8 +4449,6 @@ int gpiod_hog(struct gpio_desc *desc, const char *name,
>   /**
>    * gpiochip_free_hogs - Scan gpio-controller chip and release GPIO hog
>    * @chip:	gpio chip to act on
> - *
> - * This is only used by of_gpiochip_remove to free hogged gpios
>    */
>   static void gpiochip_free_hogs(struct gpio_chip *chip)
>   {