linux-kernel - Re: [PATCH] usb: uas: fix usb subsystem hang after power off hub port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1553786139.14990.6.camel@suse.com>
Date:   Thu, 28 Mar 2019 16:15:39 +0100
From:   Oliver Neukum <oneukum@...e.com>
To:     Kento.A.Kobayashi@...y.com, gregkh@...uxfoundation.org,
        stern@...land.harvard.edu
Cc:     usb-storage@...ts.one-eyed-alien.net, Jacky.Cao@...y.com,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH] usb: uas: fix usb subsystem hang after power off hub
 port

On Do, 2019-03-28 at 07:53 +0000, Kento.A.Kobayashi@...y.com wrote:
> Hi,
> 
> > Sorry,
> > 
> > I thought this was clear. Your patch is making the assumption that the reset is triggered by the SCSI layer. You cannot make that assumption, as there is an ioctl for resetting a USB device.
> > In case we are getting an error during the reset (our endpoints vanish), the device driver must report that to the USB layer, so the driver will always be disconnected.
> > We cannot drop errors.
> > 
> > 	Regards
> > 		Oliver
> 
> This patch modified uas_post_reset to skip rebind operation to avoid exception while -ENODEV happens not drop error.
> If uas_post_reset happens -ENODEV, usb_reset_and_verify_device must happen error.
> So,when we use ioctl(USBDEVFS_RESET) to reset device, if usb_reset_and_verify_device happens error, the error will be reported through ioctl return value. 

OK, It is possible that I am stupid. We must rebind if uas_post_reset()
fails. The driver will crash without the endpoints. Can you please
explain again in greater detail, what you are trying to achieve?

	Regards
		Oliver