linux-kernel - Re: [PATCH v3 34/36] thunderbolt: Make rest of the logging to happen at debug level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Mar 2019 08:39:49 -0700
From:   Joe Perches <joe@...ches.com>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Cc:     Michael Jamet <michael.jamet@...el.com>,
        Yehezkel Bernat <YehezkelShB@...il.com>,
        Andreas Noever <andreas.noever@...il.com>,
        Lukas Wunner <lukas@...ner.de>,
        "David S . Miller" <davem@...emloft.net>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Christian Kellner <ckellner@...hat.com>,
        Mario.Limonciello@...l.com, netdev@...r.kernel.org
Subject: Re: [PATCH v3 34/36] thunderbolt: Make rest of the logging to
 happen at debug level

On Thu, 2019-03-28 at 15:36 +0300, Mika Westerberg wrote:
> Now that the driver can handle every possible tunnel types there is no
> point to log everything as info level so turn these to happen at debug
> level instead.

trivia:

> diff --git a/drivers/thunderbolt/path.c b/drivers/thunderbolt/path.c
[]
> @@ -503,8 +503,8 @@ int tb_path_activate(struct tb_path *path)
>  					    & out_mask;
>  		hop.unknown3 = 0;
>  
> -		tb_port_info(path->hops[i].in_port, "Writing hop %d, index %d",
> -			     i, path->hops[i].in_hop_index);
> +		tb_port_dbg(path->hops[i].in_port, "Writing hop %d, index %d",
> +			    i, path->hops[i].in_hop_index);

Appears to miss a '\n' termination