linux-kernel - Re: [PATCH v3] w1: ds2408: reset on output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190328162233.GB2173@kroah.com>
Date:   Thu, 28 Mar 2019 17:22:33 +0100
From:   Greg KH <greg@...ah.com>
To:     Jean-Francois Dagenais <jeff.dagenais@...il.com>
Cc:     linux-kernel@...r.kernel.org, zbr@...emap.net, manio@...boo.net
Subject: Re: [PATCH v3] w1: ds2408: reset on output_write retry with readback

On Thu, Mar 28, 2019 at 08:22:44AM -0400, Jean-Francois Dagenais wrote:
> When we have success in 'Channel Access Write' but reading back latch
> states fails, a write is retried without doing a proper slave reset.
> This leads to protocol errors as the slave treats the next 'Channel
> Access Write' as the continuation of previous command.
> 
> This commit is fixing this by making sure if the retry loop re-runs, a
> reset is performed, whatever the failure (CONFIRM_BYTE or the read
> back).
> 
> The loop was quite due for a cleanup and this change mandated it. By
> isolating the CONFIG_W1_SLAVE_DS2408_READBACK case into it's own
> function, we vastly reduce the visual and branching(runtime and
> compile-time) noise.
> 
> Reported-by: Mariusz Bialonczyk <manio@...boo.net>
> Tested-by: Mariusz Bialonczyk <manio@...boo.net>
> Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@...il.com>
> ---
>  drivers/w1/slaves/w1_ds2408.c | 76 ++++++++++++++++++++++---------------------
>  1 file changed, 39 insertions(+), 37 deletions(-)

What changed from previous versions?  That information always goes below
the --- line.

v4 please.

thanks,

greg k-h