linux-kernel - Re: [PATCH v2 1/2] bus: tegra-aconnect: use devm_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 28 Mar 2019 17:32:48 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Sameer Pujar <spujar@...dia.com>
Cc:     treding@...dia.com, jonathanh@...dia.com,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] bus: tegra-aconnect: use devm_clk_*() helpers

On Wed, Mar 13, 2019 at 10:11:58AM +0530, Sameer Pujar wrote:
> aconnect bus driver is using pm_clk_*() interface for managing clocks.
> With this, clocks seem to be always ON. This happens on Tegra devices
> which use BPMP co-processor to manage clock resources, where clocks
> are enabled during prepare phase. This is necessary because calls to
> BPMP are always blocking. When pm_clk_*() interface is used on such
> Tegra devices, clock prepare count is not balanced till driver remove()
> gets executed and hence clocks are seen ON always. Thus this patch
> replaces pm_clk_*() with devm_clk_*() framework.
> 
> Suggested-by: Mohan Kumar D <mkumard@...dia.com>
> Reviewed-by: Jonathan Hunter <jonathanh@...dia.com>
> Signed-off-by: Sameer Pujar <spujar@...dia.com>
> ---
>  drivers/bus/tegra-aconnect.c | 64 ++++++++++++++++++++++++++++++--------------
>  1 file changed, 44 insertions(+), 20 deletions(-)

Both patches applied to for-5.2/bus, thanks.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)