linux-kernel - Re: [PATCH] gpio: mockup: fix debugfs read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMpxmJUdW4bnc0YFVdSkyUpQ4c0XkAt8Ju7Qzt4sHYtiwc1R4Q@mail.gmail.com>
Date:   Thu, 28 Mar 2019 18:01:55 +0100
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Bartosz Golaszewski <brgl@...ev.pl>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: mockup: fix debugfs read

czw., 28 mar 2019 o 17:56 Linus Walleij <linus.walleij@...aro.org> napisał(a):
>
> On Thu, Mar 28, 2019 at 5:47 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> > czw., 28 mar 2019 o 17:38 Linus Walleij <linus.walleij@...aro.org> napisał(a):
> > > On Fri, Mar 22, 2019 at 6:30 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> > >
> > > > From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> > > >
> > > > The debugfs read callback must advance ppos or users using read() on
> > > > the file descriptor will never get the EOL. This wasn't spotted before
> > > > as I was using busybox cat for testing which uses sendfile() internally
> > > > and only noticed it now when switched to cat from coreutils.
> > > >
> > > > Fixes: 2a9e27408e12 ("gpio: mockup: rework debugfs interface")
> > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
> > >
> > > Patch applied for fixes.
> > > Sorry for slow application, I was in no-wifi-land for some days.
> > >
> > > Yours,
> > > Linus Walleij
> >
> > Ugh, I was thinking about sending you a pull-request with this and a
> > subsequent fix this evening. Plus other fixes I have in my tree.
>
> Oh if it is easier for you do that, and I will drop this patch and just
> merge your PR as it arrives.
>
> Yours,
> Linus Walleij

Yes, let's do it.

Bart